Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36601 - Error when autoprovision/provision for a discovered host #10656

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

stejskalleos
Copy link
Contributor

Foreman throws an error undefined method html_safe' for nil:NilClass` when auto-provision/provision is initiated for a discovered host without selecting a host group.

What are the changes introduced in this pull request?

Safe check for nil attributes in apply_inherited_attributes

Considerations taken when implementing this change?

Provisioning discovered host without selecting a host group

What are the testing steps for this pull request?

Foreman throws error undefined method `html_safe' for nil:NilClass
when autoprovision/provision is initiated for a discovered host
without selecting a host group.
@theforeman-bot
Copy link

Issues: #36601

@stejskalleos
Copy link
Contributor Author

@ianballou review please :)

Copy link

@adarshdubey-star adarshdubey-star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acking based on code review.

@ianballou ianballou merged commit e834c88 into Katello:master Jul 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants