Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36604 - Manifest delete confirmation should be SCA-aware #10657

Merged

Conversation

jeremylenz
Copy link
Member

What are the changes introduced in this pull request?

In the Delete Manifest confirmation modal, most of the words are no longer relevant if you're using SCA. Update the wording of the <DeleteManifestModalText> to remove outdated wording.

Considerations taken when implementing this change?

What are the testing steps for this pull request?

Subscriptions > Manage Manifest > Delete > look at the wording for an SCA org vs. a non-SCA org with manifest imported.

@theforeman-bot
Copy link

Issues: #36604

@jeremylenz jeremylenz force-pushed the 36604-update-manifest-delete-message branch from 7f1f2bc to 3aafd98 Compare July 18, 2023 18:10
Copy link
Contributor

@parthaa parthaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well.

@jeremylenz jeremylenz merged commit 1896c34 into Katello:master Jul 19, 2023
5 checks passed
wbclark pushed a commit to wbclark/katello that referenced this pull request Jul 20, 2023
wbclark pushed a commit to wbclark/katello that referenced this pull request Jul 21, 2023
wbclark pushed a commit that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants