Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36609 - Fix linting errors from react/jsx-curly-brace-presence #10659

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Jul 20, 2023

What are the changes introduced in this pull request?

Fixes linting errors from react/jsx-curly-brace-presence rule

Considerations taken when implementing this change?

Not sure which lint rule got upgraded/downgraded and where! There were some packaging changes but those seem unrelated.

What are the testing steps for this pull request?

Check react test here.

@theforeman-bot
Copy link

Issues: #36609

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, APJ

Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, react/jsx-curly-brace-presence!

ACK 👍

@sjha4 sjha4 merged commit ecfb84a into Katello:master Jul 20, 2023
5 checks passed
wbclark pushed a commit to wbclark/katello that referenced this pull request Jul 20, 2023
@wbclark wbclark mentioned this pull request Jul 20, 2023
sjha4 added a commit that referenced this pull request Jul 20, 2023
…#10659) (#10661)

(cherry picked from commit ecfb84a)

Co-authored-by: Samir Jha <sjha4@ncsu.edu>
wbclark pushed a commit to wbclark/katello that referenced this pull request Jul 21, 2023
wbclark pushed a commit to wbclark/katello that referenced this pull request Jul 21, 2023
wbclark pushed a commit that referenced this pull request Jul 31, 2023
@sjha4 sjha4 deleted the fix_lint branch April 9, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants