Fixes #36613 - Enclose Content subtabs in a section #10664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36613 |
MariaAga
reviewed
Jul 27, 2023
webpack/components/extensions/HostDetails/Tabs/ContentTab/ContentTab.scss
Outdated
Show resolved
Hide resolved
jeremylenz
force-pushed
the
36613-content-subtabs-bye-bye
branch
from
cc9ff18
to
3bc7b06
Compare
|
@MariaAga Wrapped it in a |
jeremylenz
changed the title
so they won't be hidden
jeremylenz
force-pushed
the
36613-content-subtabs-bye-bye
branch
from
3bc7b06
to
6b25976
Compare
|
[test katello] |
MariaAga
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
On the new host details page, if you click Content > Packages (or Module streams or Repository sets, but for some reason not Errata) the Content subtabs bar simply disappears. The elements are still on the page; they actually have a height of 0px. I'm guessing this is something to do with the recent navigation changes in Foreman.
I fixed this by
adding a min-height to the Content subtabsenclosing the tabs in a<PageSection>like Foreman does for its host detail tabs.Considerations taken when implementing this change?
What are the testing steps for this pull request?
click around and make sure nothing disappears