Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36621 - Update name of job template to new name #10667

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

jeremylenz
Copy link
Member

@jeremylenz jeremylenz commented Jul 28, 2023

What are the changes introduced in this pull request?

app/controllers/katello/concerns/hosts_controller_extensions.rb had a hard-coded reference to the job template named "Change content source". In #10652 this template was renamed to "Configure host for new content source," which breaks the Change Content Source form.

Considerations taken when implementing this change?

I also considered changing it to look up the template by remote execution feature, but something was wrong with my REX job template setup and I don't seem to have the right feature registered.

What are the testing steps for this pull request?

Hosts > All Hosts > Click on your host > kebab > Change Content Source

Choose a content source, LCE and content view and click Submit
Make sure the resulting banner has a link to the job invocation:

image

@theforeman-bot
Copy link

Issues: #36621

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, works well

Screenshot 2023-08-01 at 09-43-51 Change host content source

@jeremylenz jeremylenz merged commit aae344d into Katello:master Aug 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants