Fixes #36593 - Repository details page shouldn't say 'enabled by default' #10673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36593 |
sjha4
force-pushed
the
repository-not-enabled-by-default
branch
from
f6c3df9
to
33a9fe1
Compare
sjha4
force-pushed
the
repository-not-enabled-by-default
branch
from
33a9fe1
to
2283980
Compare
chris1984
reviewed
Aug 2, 2023
chris1984
reviewed
Aug 2, 2023
sjha4
force-pushed
the
repository-not-enabled-by-default
branch
from
2283980
to
378cbf6
Compare
chris1984
approved these changes
Aug 2, 2023
chris1984
added
Ready for merge
and removed
Not yet reviewed
Waiting on contributor
labels
wbclark
pushed a commit
to wbclark/katello
that referenced
this pull request
Sep 7, 2023
…ult' (Katello#10673) (cherry picked from commit 6b1d742)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Change wording on repositories views to no longer say repos are enabled by default.
Considerations taken when implementing this change?
What are the testing steps for this pull request?
Go to Products > Create new repository
You should see the new message like below:
After creating the repo, go to repo details. The 2 fields should have tooltips with updated messages:
Also updated param description on repo_create. You can check that via hammer or in APIDocs.
Let me know if you see any other places this update should be made.