Fixes #36638 - Allow metadata regenerate with --force flag on API/Hammer #10681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36638 |
sjha4
force-pushed
the
allow_metadata_regenerate_force
branch
from
57745f3
to
fe62c64
Compare
jeremylenz
reviewed
Aug 4, 2023
There was a problem hiding this comment.
Thanks @sjha4
Everything works as advertised, except this:
Seems the hammer error message here includes all mirror-complete repos:
Could not republish the Content View:
Metadata republishing is dangerous on content view versions with repositories with the 'Complete Mirroring' mirroring policy.
Update mirroring policies on these repositories ["Red Hat Enterprise Linux 8 for x86_64 - BaseOS RPMs 8", "Red Hat Enterprise Linux 8 for x86_64 - AppStream RPMs 8", "JustinComplete"] or Use 'force' parameter to stop mirroring upstream metadata and regenerate metadata locally.
But I don't have the RHEL ones included in the content view:
| mirror_complete_repos = @content_view_version.repositories.joins(:root).where(root: { mirroring_policy: ::Katello::RootRepository::MIRRORING_POLICY_COMPLETE }) | ||
| if mirror_complete_repos.size > 0 && !::Foreman::Cast.to_bool(params[:force]) | ||
| fail HttpErrors::BadRequest, _("Metadata republishing is dangerous on content view versions with repositories with the 'Complete Mirroring' mirroring policy. | ||
| Update mirroring policies on these repositories #{mirror_complete_repos.pluck(:name)} or Use 'force' parameter to stop mirroring upstream metadata and regenerate metadata locally.") |
There was a problem hiding this comment.
Suggested change
| Update mirroring policies on these repositories #{mirror_complete_repos.pluck(:name)} or Use 'force' parameter to stop mirroring upstream metadata and regenerate metadata locally.") | |
| Update mirroring policies on these repositories #{mirror_complete_repos.pluck(:name)}, or use the 'force' parameter to stop mirroring upstream metadata and regenerate metadata locally.") |
| fail HttpErrors::BadRequest, _("Metadata republishing is not allowed on repositories with the 'Complete Mirroring' mirroring policy.") | ||
| if @repository.mirroring_policy == Katello::RootRepository::MIRRORING_POLICY_COMPLETE && !::Foreman::Cast.to_bool(params[:force]) | ||
| fail HttpErrors::BadRequest, _("Metadata republishing is dangerous on repositories with the 'Complete Mirroring' mirroring policy. | ||
| Change mirroring policy on the repository and try again or use 'force' parameter via hammer/API to stop mirroring upstream metadata and regenerate metadata locally.") |
There was a problem hiding this comment.
Suggested change
| Change mirroring policy on the repository and try again or use 'force' parameter via hammer/API to stop mirroring upstream metadata and regenerate metadata locally.") | |
| Change the mirroring policy on the repository and try again, or use the 'force' parameter to stop mirroring upstream metadata and regenerate metadata locally.") |
sjha4
force-pushed
the
allow_metadata_regenerate_force
branch
from
fe62c64
to
528b503
Compare
jeremylenz
reviewed
Aug 4, 2023
app/controllers/katello/api/v2/content_view_versions_controller.rb
Outdated
Show resolved
Hide resolved
sjha4
force-pushed
the
allow_metadata_regenerate_force
branch
from
528b503
to
2108375
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
The plan for Regenerating metadata on "complete_mirroring" is as follows:
a) Disallowed on the UI : Republishing on UI on repos and cv versions with complete_mirroring repos will not be allowed.
b) Allowed in hammer : only with
--force trueConsiderations taken when implementing this change?
We want to discourage users from republishing metadata locally on Pulp for repositories with complete mirroring. Disallowing on UI and only allowing via hammer/api with --force flag makes it so.
What are the testing steps for this pull request?
Check
hammer -r repository republish --id $REPO_ID --force falsevshammer -r repository republish --id $REPO_ID --force truehammer -r content-view version republish-repositories --id $VERSION_ID --force 1andhammer -r content-view version republish-repositories --id $VERSION_ID --force 0