Fixes #36641 - use Minitest namespace #10683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36640 |
evgeni
changed the title
|
Is this running against foreman develop branch and passing on older gems? Should we merge the foreman PR before or this one to get foreman CI test green? |
|
I'd prefer to merge this (right now it ran with 5.18 minitest) and then via theforeman/foreman#9786 verify it works with newer minitest too. (or you can verify the later locally too, of course) |
sjha4
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
making old code work with modern minitest
Considerations taken when implementing this change?
letting the code bit rot and pin minitest is not an option
What are the testing steps for this pull request?
CI + theforeman/foreman#9786