Fixes #36648 - Show desc and publish date on component CV add/edit modal #10685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36648 |
sjha4
force-pushed
the
cv_details_component_add
branch
from
17dd159
to
54a3b3f
Compare
jeremylenz
reviewed
Aug 10, 2023
webpack/scenes/ContentViews/Details/ComponentContentViews/ComponentContentViewAddModal.js
Show resolved
Hide resolved
|
Updated to make scroll appear on top of modal. The prop was |
sjha4
force-pushed
the
cv_details_component_add
branch
from
ec743f5
to
baf2477
Compare
sjha4
force-pushed
the
cv_details_component_add
branch
from
baf2477
to
a329e32
Compare
jeremylenz
reviewed
Aug 11, 2023
sjha4
force-pushed
the
cv_details_component_add
branch
from
a329e32
to
4761317
Compare
sjha4
force-pushed
the
cv_details_component_add
branch
from
4761317
to
0e731df
Compare
sjha4
force-pushed
the
cv_details_component_add
branch
from
0e731df
to
45eb202
Compare
|
Pushed fixes to tests 🍏 🤞🏼 |
jeremylenz
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Add 'published_at' in version label when selecting component CV version to add to composite CV.
Considerations taken when implementing this change?
What are the testing steps for this pull request?
Create some content views and publish. Add descriptions to some/all when publishing. You can also edit desc on published versions.
Create a composite content view and play around with adding/editing/bulk adding components to the composite CV.
Make sure all three(single add/edit and bulk add) look like sketch here: