Fixes #36654 - Remove dead content_view_solve_dependencies setting #10687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36654 |
chris1984
approved these changes
Aug 9, 2023
chris1984
added
Ready for merge
and removed
Not yet reviewed
Waiting on contributor
labels
|
Seems good to me..The default is false for dep_solving and we shouldn't be making it easier to turn it on for all CVs.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
content_view_solve_dependencies, which was previously used to set whether depsolving was enabled by default for new content views, but now is apparently not used anymore.Considerations taken when implementing this change?
What are the testing steps for this pull request?
Verify that the setting "content view Dependency Solving Default" is no longer there