Fixes #36674 - don't update Candlepin consumer when force-reregistering #10694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Mark CVEs unchanged in
remove_host_artifacts
. This preventsbackend_update_needed?
from erroneously returningtrue
during the process of host removal.This was manifesting when you do a force reregister with subscription-manager without having consumer certs.
Considerations taken when implementing this change?
I considered passing around some sort of
destroying_host?
variable instead, but that seemed like too many hops to me, and reminded me of React prop drilling.What are the testing steps for this pull request?
Before: The first attempt fails with
The second attempt succeeds.
After: All attempts succeed.
also test other registration flows and make sure nothing is broken