Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36674 - don't update Candlepin consumer when force-reregistering #10694

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

jeremylenz
Copy link
Member

@jeremylenz jeremylenz commented Aug 11, 2023

What are the changes introduced in this pull request?

Mark CVEs unchanged in remove_host_artifacts. This prevents backend_update_needed? from erroneously returning true during the process of host removal.

This was manifesting when you do a force reregister with subscription-manager without having consumer certs.

Considerations taken when implementing this change?

I considered passing around some sort of destroying_host? variable instead, but that seemed like too many hops to me, and reminded me of React prop drilling.

What are the testing steps for this pull request?

rm -rf /etc/pki/consumer/*
subscription-manager register --force --username=admin --password=changeme --org=Default_Organization --environment=Library

Before: The first attempt fails with

Registering to: centos8-katello-devel-stable.example.com:443/rhsm
Unit 547cf5fd-3ff0-44d9-b26c-5944bbbb9fbd has been deleted (HTTP error code 410: Gone)

The second attempt succeeds.

After: All attempts succeed.

also test other registration flows and make sure nothing is broken

@theforeman-bot
Copy link

Issues: #36674

Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great to me!

@jeremylenz jeremylenz merged commit eb2d255 into Katello:master Aug 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants