Fixes #36684 - allow single_content_view in ContentFacet::Jail #10699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36684 |
|
👀 @ianballou @jeremylenz in theforeman/foreman#9478 you tested this -- was this with Safe Mode off? |
Otherwise the Ansible Inventory report template doesn't render properly when Safe Mode is on. Same for single_lifecycle_environment and KTEnvironment#id. Fixes: c33da7a
|
Looks like |
jeremylenz
approved these changes
Aug 16, 2023
|
Can we get this picked to 4.8 and 4.9? 😻 |
wbclark
pushed a commit
to wbclark/katello
that referenced
this pull request
Sep 7, 2023
wbclark
pushed a commit
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Allow single_content_view in ContentFacet::Jail
Otherwise the Ansible Inventory report template doesn't render properly when Safe Mode is on.
Same for single_lifecycle_environment and KTEnvironment#id.
Considerations taken when implementing this change?
none
What are the testing steps for this pull request?