Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36765 - add ability to export and import debian content #10749

Merged
merged 1 commit into from Feb 14, 2024

Conversation

hstct
Copy link
Contributor

@hstct hstct commented Sep 20, 2023

This PR depends on the following pulp_deb change which not yet released: pulp/pulp_deb#893

So I'm opening this as a draft for now

@theforeman-bot
Copy link

Can one of the admins verify this patch?

@lfu
Copy link
Member

lfu commented Sep 20, 2023

Please ping @ianballou when it is ready for review.

@quba42
Copy link
Contributor

quba42 commented Dec 13, 2023

This requires pulp_deb >= 3.0.1 to work, which we are trying to get packaged here: theforeman/pulpcore-packaging#819

As soon as the packaging PR is merged, I would consider this ready for review.

@quba42
Copy link
Contributor

quba42 commented Dec 18, 2023

pulp_deb 3.0.1 is merged and available for nightly: http://yum.theforeman.org/pulpcore/nightly/el8/x86_64/python3.11-pulp-deb-3.0.1-1.el8.noarch.rpm

@hstct hstct marked this pull request as ready for review January 2, 2024 08:42
@ianballou
Copy link
Member

[test katello]

@hstct hstct force-pushed the add-import-export-for-deb-content branch from f65f92e to 724f237 Compare January 11, 2024 13:09
@hstct
Copy link
Contributor Author

hstct commented Jan 11, 2024

The failing test should now work!

@hstct hstct force-pushed the add-import-export-for-deb-content branch from 724f237 to 2685f03 Compare January 11, 2024 14:19
@m-bucher
Copy link
Contributor

[test katello]

Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well for me! Tested repository, library, and content view version export/import.

@ianballou
Copy link
Member

We can merge this when the tests pass again.

@ianballou
Copy link
Member

Needs a rebase then we can merge assuming the tests pass.

@m-bucher m-bucher force-pushed the add-import-export-for-deb-content branch from 2685f03 to 3d0bc14 Compare February 7, 2024 15:33
@parthaa
Copy link
Contributor

parthaa commented Feb 9, 2024

[test katello]

@ianballou ianballou merged commit c384fed into Katello:master Feb 14, 2024
10 of 15 checks passed
@hstct hstct deleted the add-import-export-for-deb-content branch February 14, 2024 20:07
sbernhard pushed a commit to ATIX-AG/katello that referenced this pull request Feb 29, 2024
sbernhard pushed a commit to ATIX-AG/katello that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants