Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #17748 - Filter out who to send the emails to #10788

Merged
merged 1 commit into from Nov 10, 2023

Conversation

adamruzicka
Copy link
Member

What are the changes introduced in this pull request?

Previously the emails were sent out to all the users which opt-in for it, even if those users were disabled or didn't have mail notification checkbox enabled.

What are the testing steps for this pull request?

  1. Set up a user, opt in for repo sync failure email notifications, disable the user
  2. Run a repo sync that will fail
  3. The user from 1 shouldn't get an email

@pnovotny
Copy link

pnovotny commented Nov 6, 2023

LGTM, tested with the Packit builds.
Disabled user or user with disabled email doesn't receive the email notification about repo sync failure.

Copy link
Contributor

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, not sure whom I can ping here though :/ maybe @jeremylenz could take a look? :)

Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acking based on @pnovotny and @ofedoren

Thanks all!

@jeremylenz jeremylenz merged commit 9b51612 into Katello:master Nov 10, 2023
6 checks passed
@adamruzicka adamruzicka deleted the emails-vol2 branch November 13, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants