Fixes #36921 - Host queue not added to sidekiq #10799
Conversation
The host queue is added too early during the initialization which is before the settings for Foreman plugins are loaded. Fix it by removing the setting check because pool size is no longer define here. Since Dynflow migrated to Sidekiq, the concurrency is defined externally in the Sidekiq workers configuration.
hao-yu
force-pushed
the
36921_fix_missing_hosts_queue
branch
from
e274579
to
3f47b0b
Compare
|
rpm-build test keeps failing due to an issue mentioned at #10782 That should be resolved, but it's still happening when I re-run that step Maybe I need to re-run all steps for the change to be propagated |
There was a problem hiding this comment.
That did the trick. I guess the buildroot on fedora copr is associated with the PR, so re-running it didn't fix the issue. Just to test, I opened a duplicate PR (above) and from this I got the working rpm-build test at https://dashboard.packit.dev/results/copr-builds/1168237
As for the actual functionality, I previously tested this using the katello nightly box on forklift and found that it works fine (devel box didn't work to test it since it doesn't have dynflow-sidekiq@worker-hosts-queue-1.service)
|
Thanks @hao-yu ! |
The host queue is added too early during the initialization which is before the settings for Foreman plugins are loaded.
Fix it by removing the setting check because pool size is no longer define here. Since Dynflow migrated to Sidekiq, the
concurrency is defined externally in the Sidekiq workers configuration.