Fixes #36968 - Add container manifest list to UI and aria-label for repo icon #10821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianballou
reviewed
Dec 14, 2023
| @@ -55,6 +56,11 @@ const AdditionalCapsuleContent = ({ counts }) => { | |||
| {`${dockerManifestCount} Container manifests`}<br /> | |||
| </> | |||
| } | |||
| {dockerManifestListCount > 0 && | |||
| <> | |||
| {`${dockerManifestListCount} Container manifest lists`}<br /> | |||
There was a problem hiding this comment.
One thing I realized -- it doesn't look like the container bits are getting translated (except ansible collections?) for some reason:
vs
|
Added https://projects.theforeman.org/issues/36988 for adding the CV version container manifest list counts and comparisons.. |
ianballou
pushed a commit
to ianballou/katello
that referenced
this pull request
Dec 19, 2023
…epo icon (Katello#10821) * Fixes #36968 - Add container manifest list to UI and aria-label for repo icon * Fixes #36968 - Add translations to content counts (cherry picked from commit c40e0d8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Considerations taken when implementing this change?
What are the testing steps for this pull request?
Create a docker repo with manifest lists. ex: libpod/testimage from quay.io
Sync repo and have the repo sync to a capsule
Check the capsule content page to make sure you see manifest lists in content counts.
Also do an inspect element on repo type icon. It should have aria-lebel = Repo type