Refs #35713 - correctly call methods with kwargs #10845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 11, 2024
|
@ofedoren I think this would also be relevant to our Ruby 3 work. |
ofedoren
approved these changes
Jan 17, 2024
|
It was broken by #10744 because that PR both added the methods and called them incorrectly, and I didn't catch it before merging. |
|
@jeremylenz then shouldn't this be |
|
I usually don't use "Refs" because I don't trust our automations (mostly Jira/Bugzilla) not to duplicate or mess up tickets. I can change it if you feel strongly. |
|
Refs should be used if it's the same issue, within the same release. Otherwise you mess up automation, like cherry picks |
jeremylenz
changed the title
jeremylenz
force-pushed
the
37045-kwargs-package-names
branch
from
7ca7eec
to
0250c25
Compare
|
updated Redmine and commit messages. |
sbernhard
pushed a commit
to ATIX-AG/katello
that referenced
this pull request
Feb 29, 2024
(cherry picked from commit 3ac7cdd)
sbernhard
pushed a commit
to ATIX-AG/katello
that referenced
this pull request
Mar 8, 2024
(cherry picked from commit 3ac7cdd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
In #10744 package_names_for_job_template was extracted into two new methods,
yum_names_for_job_templateanddeb_names_for_job_template.These new methods accept only keyword arguments, but are called only with regular non-kwargs.
This change fixes that and properly calls the methods with kwargs.
Considerations taken when implementing this change?
What are the testing steps for this pull request?
Install or remove a package via the new host details UI and make sure that the job template renders without errors.