Fixes #37111 - use preloaded count #10866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test katello] |
sjha4
approved these changes
Feb 6, 2024
sbernhard
added a commit
to ATIX-AG/katello
that referenced
this pull request
Feb 29, 2024
(cherry picked from commit 14b63bd)
sbernhard
added a commit
to ATIX-AG/katello
that referenced
this pull request
Mar 8, 2024
(cherry picked from commit 14b63bd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use size instead of count which just reuse the preloaded data if already available. See https://www.speedshop.co/2019/01/10/three-activerecord-mistakes.html
Before
[root@or v2]# grep SELECT /tmp/cv_opt2.log | grep COUNT | wc -l
47
Afterwards:
[root@or v2]# grep SELECT /tmp/cv_opt2.log | grep COUNT | wc -l
27
(20 CVs)