Fixes #37170 - Support expiring in information in subscription report #10896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjha4
force-pushed
the
expiring_subs_mailer
branch
from
e9a05e2
to
d566b3a
Compare
sjha4
changed the title
sjha4
force-pushed
the
expiring_subs_mailer
branch
2 times, most recently
from
deea2f2
to
b116aa1
Compare
|
[test katello] |
|
Test failures seem related. |
|
Updated test.. 👍🏼 |
sjha4
force-pushed
the
expiring_subs_mailer
branch
from
b116aa1
to
61ad042
Compare
|
[test Redmine issues] |
jeremylenz
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
@sjha4 I can't get the Redmine issues check to re-run, it may need a rebase.
APJ
sjha4
force-pushed
the
expiring_subs_mailer
branch
from
61ad042
to
3052d3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Adds support for "expiring in " filter for subscription reports.
Considerations taken when implementing this change?
What are the testing steps for this pull request?
Test with : theforeman/foreman#10057
Make sure you can run that report with relevant Expiring in filters.