Fixes #37277 - Fix ACS randomly failing VCR tests #10941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test_bad_promote_out_of_sequence – Katello::Api::V2::ContentViewVersionsControllerTest is an unrelated failure, but I'll add the fix in here. |
ianballou
force-pushed
the
37277-fix-acs-tests
branch
from
82312cd
to
f804c42
Compare
|
Pipeline is green! @sjha4 |
sjha4
reviewed
Mar 18, 2024
| @@ -108,7 +108,7 @@ def create | |||
| if acs.content_type == ::Katello::Repository::FILE_TYPE && acs.subpaths.present? | |||
| paths = insert_pulp_manifest!(paths) | |||
| end | |||
| response = api.alternate_content_source_api.create(name: generate_backend_object_name, paths: paths, | |||
| response = api.alternate_content_source_api.create(name: generate_backend_object_name, paths: paths.sort, | |||
sjha4
approved these changes
Mar 18, 2024
qcjames53
pushed a commit
to qcjames53/katello
that referenced
this pull request
Mar 19, 2024
(cherry picked from commit 6d93801)
qcjames53
added a commit
that referenced
this pull request
Mar 19, 2024
* Refs #37148 - Remove removed_widgets override (#10927) (cherry picked from commit 40a70ce) * Fixes #35215 - Handle cloned hostgroups in hosts_and_hostgroups_helper (#10894) (cherry picked from commit e3d46c6) * Fixes #36979 - Remove cdn_ssl_version setting This was originally added to allow downgrading the CDN connection SSL version for compatibility with much older proxy servers. That should be less of a concern now. We do still set a value of TLS v1.2 for the min_version, but only because ruby/openssl#709 prevents using the system-wide crypto policy for now. In the future, that can be removed as well, restoring control to the user at the OS level. (cherry picked from commit 78fcba9) * Fixes #37277 - Fix ACS randomly failing VCR tests (#10941) (cherry picked from commit 6d93801) * Fixes #37240 - Fix CCV duplicate repo warning (#10928) (cherry picked from commit 02fc313) --------- Co-authored-by: Jeremy Lenz <jlenz@redhat.com> Co-authored-by: William Bradford Clark <wclark@redhat.com> Co-authored-by: Ian Ballou <ianballou67@gmail.com> Co-authored-by: Markus Bucher <bucher@atix.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Should fix the ruby tests run in the GH actions. There was ordering randomness with ACS paths.
Considerations taken when implementing this change?
Sorting during ACS creation / updating should have a very minimal affect on performance. Plus, it reduces randomness.
What are the testing steps for this pull request?
See that that tests all pass.