Fixes #37309 - Add Katello columns to new host index page #10950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylenz
force-pushed
the
37309-katello-columns
branch
2 times, most recently
from
9c2d2e7
to
77aa1d5
Compare
jeremylenz
force-pushed
the
37309-katello-columns
branch
from
77aa1d5
to
ba4d0a8
Compare
|
updated weights and default values |
jeremylenz
force-pushed
the
37309-katello-columns
branch
from
ba4d0a8
to
0acff9d
Compare
|
Should the links here work yet? |
ianballou
reviewed
Apr 10, 2024
Yes! I am not able to reproduce this. Is it still an issue for you? |
jeremylenz
force-pushed
the
37309-katello-columns
branch
from
0acff9d
to
f3e96eb
Compare
|
rebased |
ianballou
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Tested with theforeman/foreman#10110. Works well. Also checked that the Content fields are properly blank for non-registered hosts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Goes with theforeman/foreman#10110
Adds columns to Foreman's new HostsIndex page
Considerations taken when implementing this change?
I renamed "Registered" to "Registered at" because the value is a time, not a boolean
What are the testing steps for this pull request?
Check out the Foreman PR
Click "Manage columns"
Add some columns and make sure everything works as expected.