Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37403 - make repository rpm ID sequence bigint #10983

Conversation

ianballou
Copy link
Member

@ianballou ianballou commented May 2, 2024

What are the changes introduced in this pull request?

Makes katello_repository_rpms_id_seq a bigint since users are hitting the ID limit.

Considerations taken when implementing this change?

I was thinking if we need to make other fields larger, however no user has complained so I think it should be safe to only increase this one.

What are the testing steps for this pull request?

  1. In psql, look at select * from pg_sequences where sequencename='katello_repository_rpms_id_seq';
  2. See that the sequence has the type of integer
  3. Run the migration
  4. Run the query above again
  5. See that the data type is now bigint
  6. Rollback the query
  7. Run ALTER SEQUENCE katello_repository_rpms_id_seq AS bigint; in psql
  8. Run the migration again. Ensure there are no errors
  9. Check that the ID sequence data type is still bigint.

Copy link
Contributor

@m-bucher m-bucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, since the id column in katello_repository_rpms is already bigint.

I am thinking about suggesting to do the same for katello_repository_debs. I must admit though that I have not heard from anyone who has hit the MAX_INT, yet.
It has to be a separate ticket and PR anyway, so this one is IMHO good to go.

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, works as expected in the testing steps.

@chris1984 chris1984 self-assigned this May 6, 2024
@ianballou ianballou merged commit b405249 into Katello:master May 6, 2024
23 checks passed
@ianballou ianballou deleted the 37403-bigint-katello_repository_rpms_id_seq branch May 6, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants