Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37571 - Call 'bind_entitlement' with splatted kwargs #11040

Merged

Conversation

jeremylenz
Copy link
Member

What are the changes introduced in this pull request?

See the title. Not doing this was breaking adding subscriptions to a manifest on EL9:

19:35:32 rails.1   | 2024-06-18T19:35:32 [E|bac|f4e9a8f2] wrong number of arguments (given 1, expected 0) (ArgumentError)
19:35:32 rails.1   |  f4e9a8f2 | /home/vagrant/katello/app/lib/katello/resources/candlepin/upstream_consumer.rb:70:in `bind_entitlement'
19:35:32 rails.1   |  f4e9a8f2 | /home/vagrant/katello/app/lib/actions/katello/upstream_subscriptions/bind_entitlement.rb:7:in `run'

Considerations taken when implementing this change?

Still needs testing to make sure it works on EL8 as well.

What are the testing steps for this pull request?

Add subscriptions to your manifest
make sure the task completes with no errors

@jeremylenz jeremylenz force-pushed the 37571-bind-keyword-args-to-an-allocation branch from f71252a to 7fb8b4e Compare June 20, 2024 19:21
@jeremylenz
Copy link
Member Author

fixed test

Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works!

@jeremylenz
Copy link
Member Author

Ian tested on EL9 and I tested on EL8. We both successfully bound entitlements to our allocations.

@jeremylenz jeremylenz merged commit 9fa4a7d into Katello:master Jun 21, 2024
24 of 25 checks passed
parthaa pushed a commit to parthaa/katello that referenced this pull request Jun 26, 2024
parthaa pushed a commit that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants