Migration to Asset Pipeline #1907
Conversation
account for new manifest files.
Conflicts: src/Gemfile32 src/db/schema.rb
stylesheets out of sections/ directory to make references to image urls more uniform. Includes spec updates for packages required to perform assets pipeline.
styling comments.
|
A couple minor concerns. First, all your copyrights still say 2012 and I think that was recently updated? Also, one of my concerns is that we're not using the asset pipeline for what it's intended. It's suppose to compile all the javascript assets together to speed up requests via caching and instead we're creating separate javascript files for each page. |
| else | ||
| false | ||
| end | ||
| } |
There was a problem hiding this comment.
I'm guessing you used curly braces here because you ran into presedence problems with do..end? If so, you could use parentheses which would allow you to use do end (which is typically recommended for multi-line blocks of code).
|
Depending on who you ask, one file vs. lots of files is debated hotly. The only consensus I have ever read from people that you want a balance between the size of your JS files and the number of JS files to prevent a degradation to the user experience. I am not shrugging it off as shouldn't be investigated, but I don't think this pull request should necessarily address that given our time frame. The production installs I have used so far have been blazing fast with no impact to user experience as of yet. Since @daviddavis and @waldenraines have raised this as a concern and if they are agreeable, I'll add backlog item to investigate this for a future sprint? |
|
+1 |
|
@daviddavis tracked here https://trello.com/card/investigate-ui-asset-organization/511bd7357c52d1c61c00510e/68 FYI: New navigation and nutupane are introducing Angular as a core library that components and UI are built off of. |
|
@daviddavis Updated with your comments, please review |
| @@ -0,0 +1,17 @@ | |||
| /** | |||
| Copyright 2012 Red Hat, Inc. | |||
There was a problem hiding this comment.
I'm still seeing 2012 in a lot of files.
|
ACK pending copyright fix. |
|
@daviddavis updated copyright years |
|
ACK |
Rails 3.2 provides a way to incorporate assets within the project without needing an outside library (previously Jammit). This pull request migrates us off of Jammit and on to the Rails 3.2 asset pipeline with the following implications:
Testing of this work: