Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system groups - provide user oppty to delete the systems in a group when deleting the group #221

Merged
merged 4 commits into from Jun 19, 2012
Merged

system groups - provide user oppty to delete the systems in a group when deleting the group #221

merged 4 commits into from Jun 19, 2012

Conversation

bbuckingham
Copy link
Member

The purpose of this pull request is to allow the user the ability to delete all systems associated with a system group when they delete the actual group, in the UI.

Basic scenario:

  • user navigates to a system group that contains 1 or more systems
  • user clicks "Remove System Group"
  • user is prompted to confirm that they want to delete the group
    • if user indicates 'yes', the user is prompted to see if they would also like to delete the systems in the group (with a warning)...
      • if user clicks 'yes', the systems and group are destroyed
      • if user clicks 'no', delete only the group', only the group is destroyed
      • if user clicks 'cancel', no changes occur

NOTE: user will only be given the opportunity to delete systems, if they have the correct permissions

In order to support the above, there were a couple of small refactors included:

  1. moved the system group headers to a partial _tupane_header.html.haml
  2. updated the existing customConfirm to include additional 'settings' that the user can pass in. This was to allow for things such as, adding a warning msg, supporting optional cancel button, allow caller to customize button text...etc. In order to support this all, current usage was updated.

@bbuckingham
system groups - update views to use _tupane_header partial
b7d142b 
This change will place the headers in a single partial for reuse.
@bbuckingham
customConfirm - add more settings and refactor current usage
5e8121b 
This commit contains some modifications to the customConfirm
action to provide the user a little more flexibility in it's behavior.
The changes include, ability to specify a secondary warning message,
setting the text for the yes/no buttons and adding an optional
cancel button.  (These changes were not previously needed; however,
they will be useful to support the System Groups deletion.)

This commit also contains the changes to the current users to
use the new 'settings' object to pass input to the customConfirm.
@bbuckingham
system groups - ui - provide user option to delete systems when delet…
3cffdc7 
…ing group

This commit contains changes to allow the user the opportunity to delete
the systems in the group when deleting the group itself.
@bbuckingham
Merge remote-tracking branch 'upstream/master' into fork-group_delete…
1e83cbf 
…_systems
@knowncitizen
Copy link
Contributor

I like the cut of this pull request's jib. ACK

@ghost ghost assigned ehelms Jun 18, 2012
ehelms added a commit that referenced this pull request Jun 19, 2012
@ehelms
Merge pull request #221 from bbuckingham/fork-group_delete_systems
76e9018 
system groups - provide user oppty to delete the systems in a group when deleting the group
@ehelms ehelms merged commit 76e9018 into Katello:master Jun 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ehelms ehelms

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bbuckingham @knowncitizen @ehelms