Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default_info - converting apply to sync #2404

Merged
merged 1 commit into from Jun 3, 2013
Merged

default_info - converting apply to sync #2404

merged 1 commit into from Jun 3, 2013

Conversation

komidore64
Copy link
Contributor

  • db migration adding a new 'default' column for custom_info
  • updating the schema
  • re-wording from 'apply' to 'sync'

default_info "apply" takes the default_info keys that are specified on an org,
and syncs them with all the systems (or distributors) under that org. this
includes adding custom_info but also removing custom_info
(that may have values attached to it).

@@ -59,11 +59,14 @@ KT.default_info = (function() {
$("#apply_default_info_button").removeClass("processing");
allow_default_info_manipulation(true);
task_status_updater.stop();
count = data['result'].length;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a var: 'var count = ...' or just put that right into the if statement

- db migration adding a new 'default' column for custom_info
- updating the schema
- re-wording from 'apply' to 'sync'
- fixing spec tests

default_info "apply" takes the default_info keys that are specified on
an org, and syncs them with all the systems (or distributors) under that
org. this includes adding custom_info but also removing custom_info
(that may have values attached to it).
@komidore64
Copy link
Contributor Author

@thomasmckay boom

@thomasmckay
Copy link
Member

ack

komidore64 added a commit that referenced this pull request Jun 3, 2013
default_info - converting apply to sync
@komidore64 komidore64 merged commit aafed33 into Katello:master Jun 3, 2013
@komidore64 komidore64 deleted the default-info-sync branch June 3, 2013 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants