This makes third level navigation in panel sticky. #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
What is special about the packages? Is it because it points to a different controller? |
|
It's because part of the route after id contains slash. And the last_ajax_panelpage is extracted from link as the part after last slash in url. Another way could be to check for id (/number/) and take all after it but i don't know if we can rely on this. |
|
I would suggest either cleaning up that route to leave off the trailing / or making the tokenizer a bit smarter. Putting specific routes in here is not the way to go. ("new" is a special case) |
|
@thomasmckay Is it smart enought now? Can we rely on /katello|sam|whatever/some_resource/some_id/whate/ver ? extract_panelpage takes everything from the 4th part. |
thomasmckay
pushed a commit
that referenced
this pull request
Jul 19, 2012
This makes third level navigation in panel sticky.
thomasmckay
pushed a commit
that referenced
this pull request
Apr 27, 2013
This makes third level navigation in panel sticky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selected tab maintain selected for all items from left column.
I tried to make work the sticky 3rd level navigation. It is working but I am not very satisfied with it because of the workaround for 'system_packages/packages'. I tried to convince simple-navigation to include additional info to the link (something like data-rel='system_package/packages') but I failed. Do you know a way how to do it better?