system groups - few small bug fixes #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will close the copy widget if the user has it open and then either clicks navigates to a different pane or group.
…s w/o providing any If the user sends a request to add system groups to a system without providing one or more group names, generate an error. This commit also generates an error, if the system record does not exist.
- do not allow user to set max systems to 0 (doesn't make sense) - do not give user the "may not be less than the number of systems associated with the system group." validation message if there are no systems currently assigned...
Updated the query on the Systems -> [systemX] -> System Groups pane to properly determine the list of system groups that should be included in the menu selector. This includes any groups that the system is not already assigned to and any groups that have not reached their max membership.
ghost
assigned 
|
looks good |
parthaa
added a commit
that referenced
this pull request
Jul 20, 2012
system groups - few small bug fixes
parthaa
added a commit
that referenced
this pull request
Apr 27, 2013
system groups - few small bug fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request includes a few small bug fixes on system groups:
system groups - fix query on systems -> system groups pane
system groups - updates to validation of max_systems
839265 - system - generate proper error if user attempts to add groups w/o providing any
system groups - close copy widget when switching objects or panes