API v2 - specify API version via headers or in url #3431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to have some tests for this with |
| req.accept =~ /version=([\d\.]+)/ | ||
| if (version = $1) # version is specified in header | ||
| header_match = req.accept.match(/version=([\d\.]+)/) | ||
| route_match = req.fullpath.match(/api\/v\d\//) |
There was a problem hiding this comment.
I'm wondering if %r{api/v\d/} would be easier to read here?
|
ACK pending comments and Jenkins. Thanks again for working on this. |
|
Opened issue http://projects.theforeman.org/issues/3754 for the tests ACK pending Jenkins. |
| @@ -18,8 +18,13 @@ def initialize(options) | |||
| end | |||
|
|
|||
| def matches?(req) | |||
| req.accept =~ /version=([\d\.]+)/ | |||
| if (version = $1) # version is specified in header | |||
| header_match = req.accept.match(/version=([\d\.]+)/) | |||
There was a problem hiding this comment.
It looks like request.accept could return nil. If you update this to the following, I think it should fix the breaking test:
header_match = req.accept.try(:match, /version=([\d\.]+)/)
Katello::Api::V1::UsersControllerTest.test_list_owners_username
|
closing due to merge of PR continued in #3461. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.