updates for v2 API and ping controller #3438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
| def respond_for_show(options = {}) | ||
| respond_with_template_resource(options[:template] || 'show', controller_name, options) | ||
| end | ||
| COLLECTION_ROOT = "results" |
There was a problem hiding this comment.
Why set the collection root here instead of directly in the template?
There was a problem hiding this comment.
no particular reason. i can move.
|
going to use layouts instead of templates inside of templates. layouts shouldn't break tests |
these files were moved: app/views/api/v2/common/collection_resource.json.rabl --> app/views/katello/api/v2/common/collection_resource.json.rabl app/views/api/v2/common/single_resource.json.rabl --> app/views/katello/api/v2/common/single_resource.json.rabl
also included is optional root-node for single resource responses Conflicts: app/controllers/katello/api/v2/api_controller.rb
8 tasks
|
closing due to merge of PR continued in #3462. |
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will be included in a separate PR that contains collection responses