Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscription totals portlet to the dashboard #3460

Merged
merged 1 commit into from
Dec 5, 2013

Conversation

mkelley33
Copy link
Contributor

This "portlet" (aka widget) on the dashboard implements user story
"As a dashboard user, I want to see current subscription totals" in
SAM backlog sprint 10.

This portlet adds the following functionality:

  • It links to the subscriptions search page, where the results shown
    are filtered by date range using elasticsearch.
  • The counts shown are calculated from new methods on the Pool class
    in the katello app's models.
  • I add a helper method to the DashboardHelper that permits a portlet
    or widget to exclude the quantity dropdown from displaying in cases
    such as this where quantity doesn't make sense.

@ehelms
Copy link
Member

ehelms commented Dec 4, 2013

Looks like you have a strange merge commit mixed in.


require 'minitest_helper'

class PoolTest < MiniTest::Rails::ActiveSupport::TestCase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be wrapped in module Katello and that it should inherit from just ActiveSupport::TestCase

@ehelms
Copy link
Member

ehelms commented Dec 5, 2013

APJ for me

This "portlet" (aka widget) on the dashboard implements user story
"As a dashboard user, I want to see current subscription totals" in
SAM backlog sprint 10.

This portlet adds the following functionality:

- It links to the subscriptions search page, where the results shown
  are filtered by date range using elasticsearch.
- The counts shown are calculated from new methods on the Pool class
  in the katello app's models.
- I add a helper method to the DashboardHelper that permits a portlet
  or widget to exclude the quantity dropdown from displaying in cases
  such as this where quantity doesn't make sense.
mkelley33 added a commit that referenced this pull request Dec 5, 2013
Add subscription totals portlet to the dashboard
@mkelley33 mkelley33 merged commit c8160f2 into Katello:master Dec 5, 2013
@mkelley33 mkelley33 deleted the subscriptions-widget branch December 5, 2013 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants