Setting titles on old and new katello pages #3666
Conversation
| @@ -1,3 +1,5 @@ | |||
| <span page-title="{{ 'Subscriptions for: ' | translate }} {{ system.name }}" model="system"></span> | |||
There was a problem hiding this comment.
This is not as clean as I might have hoped. Does the form below not work for this purpose?
<span page-title translate>Subscriptions for {{ system.name }}</span>
There was a problem hiding this comment.
Hmm, I didn't think about using transclusion, I could try that.
There was a problem hiding this comment.
I have this working:
<span page-title ng-model="system">System {{ system.name }}</span>But in order to get the translate directive to work we'd have to add another element or use the wonky syntax above because of this:
Error: [$compile:multidir] Multiple directives [translate, pageTitle] asking for transclusion on: <span page-title="" translate="" ng-model="system">
Either of these work:
<span page-title ng-model="system">{{ 'System' | translate }} {{ system.name }}</span><span translate><span page-title ng-model="system">System {{ system.name }}</span></span>I couldn't get translate inside of page-title to work, however.
So do you have a preference?
|
@ehelms updated. |
| @@ -63,7 +66,7 @@ angular.module('Bastion.test-mocks').factory('MockResource', ['$q', function($q) | |||
| $delete: function(callback) { | |||
| callback(); | |||
| }, | |||
| $promise: $q.defer().promise | |||
| $promise: deferred.promise | |||
There was a problem hiding this comment.
Are we sure we want the same promise for every mockResource?
There was a problem hiding this comment.
I thought about that, but it should be fine since a new MockResource is injected each time in the beforeEach()s.
There was a problem hiding this comment.
I was more thinking of the case where you had multiple objects in your collection that are all generated from this template resource.
There was a problem hiding this comment.
As discussed in IRC, will update to use mock $q.
|
ACK |
Setting titles on old and new katello pages
Todo