Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code that has been replaced by bastion/v2 APIs. #3731

Merged
merged 1 commit into from Feb 28, 2014

Conversation

waldenraines
Copy link
Contributor

Delete several old and unused UI controllers, views, and tests
as well as removing unused functionality from remaining
bastion-only UI controllers.

@waldenraines
Copy link
Contributor Author

Running tests on master:

[walden@wraines-sandbox foreman (develop)]$ time rake test:katello

...

real    5m49.095s
user    5m39.928s
sys 0m6.792s

Running tests on remove-cruft:

[walden@wraines-sandbox foreman (develop)]$ time rake test:katello

...

real    4m44.229s
user    4m35.165s
sys 0m6.662s

@ehelms
Copy link
Member

ehelms commented Feb 25, 2014

@waldenraines
Copy link
Contributor Author

@ehelms I don't believe I am, can you show me where I am doing that?

@ehelms
Copy link
Member

ehelms commented Feb 25, 2014

@waldenraines looked at the wrong controller, everything here looks good to me and the tests pass. I have not checked out the code to test any old UI pieces.

@ehelms
Copy link
Member

ehelms commented Feb 25, 2014

@waldenraines what about unused JS? styles related to this pages?

@waldenraines
Copy link
Contributor Author

@ehelms that's good point, my main goal here was to speed up testing. Do you have a strong preference that I remove JS/CSS in this PR?

@ehelms
Copy link
Member

ehelms commented Feb 25, 2014

@waldenraines not strong, but seems like we should take all the garbage to the curb at one time ya know

@waldenraines
Copy link
Contributor Author

@ehelms updated.

@ehelms
Copy link
Member

ehelms commented Feb 27, 2014

I saw no obvious issues when testing the UI or from the code. ACK

@bbuckingham
Copy link
Member

ACK.

@thomasmckay, @komidore64, can one of you look this over from a headpin perspective?

@komidore64
Copy link
Contributor

i see that you're deleting two repositories view. make sure you can still do everything in the rh repositories page.

@thomasmckay thomasmckay reopened this Feb 27, 2014
@thomasmckay
Copy link
Member

ack

@waldenraines
Copy link
Contributor Author

Had mistakenly removed organizations/_edit_override.html.erb and organizations/_step_1_override.html.erb. Noticed this while testing RH repositories.

Added those back, please re-ACK, should be good to go now.

@thomasmckay
Copy link
Member

re-ack

@komidore64
Copy link
Contributor

ack

Delete several old and unused UI controllers, views,
javascript files, styles, and tests as well as removing
unused functionality from remaining bastion-only UI controllers.
waldenraines pushed a commit that referenced this pull request Feb 28, 2014
Remove code that has been replaced by bastion/v2 APIs.
@waldenraines waldenraines merged commit fe6c40a into Katello:master Feb 28, 2014
@waldenraines waldenraines deleted the remove-cruft branch February 28, 2014 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants