New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove code that has been replaced by bastion/v2 APIs. #3731
Conversation
Running tests on
Running tests on
|
@waldenraines I believe you are currently deleting - https://github.com/Katello/katello/blob/master/engines/bastion/app/assets/javascripts/bastion/organizations/organization.factory.js#L40 which will break a few pages. |
@ehelms I don't believe I am, can you show me where I am doing that? |
@waldenraines looked at the wrong controller, everything here looks good to me and the tests pass. I have not checked out the code to test any old UI pieces. |
@waldenraines what about unused JS? styles related to this pages? |
@ehelms that's good point, my main goal here was to speed up testing. Do you have a strong preference that I remove JS/CSS in this PR? |
@waldenraines not strong, but seems like we should take all the garbage to the curb at one time ya know |
@ehelms updated. |
I saw no obvious issues when testing the UI or from the code. ACK |
ACK. @thomasmckay, @komidore64, can one of you look this over from a headpin perspective? |
i see that you're deleting two repositories view. make sure you can still do everything in the rh repositories page. |
ack |
Had mistakenly removed organizations/_edit_override.html.erb and organizations/_step_1_override.html.erb. Noticed this while testing RH repositories. Added those back, please re-ACK, should be good to go now. |
re-ack |
ack |
Delete several old and unused UI controllers, views, javascript files, styles, and tests as well as removing unused functionality from remaining bastion-only UI controllers.
Remove code that has been replaced by bastion/v2 APIs.
Delete several old and unused UI controllers, views, and tests
as well as removing unused functionality from remaining
bastion-only UI controllers.