Code for Org Create orchestration

[parthaa]

No description provided.

[iNecas]

I think we still need to include the module, as there is the mapping defined. We just need to disable the autoreindex when creating it with dynflow (organization.disable_auto_reindex!)

[bkearney]

please make sure to check the hammer org command that it still works with this.

@bkearney they will once -> https://github.com/iNecas/foreman-tasks/pull/35 gets merged and a new foreman-tasks gem gets rolled out by @iNecas .. .

[jlsherrill]

this indentation looks wonky

[jlsherrill]

Tested and all seems well. Will ack once small formatting issues addressed.

[jlsherrill]

i would think you'd want:

if Katello.config.use_cp
          plan_action(Candlepin::Environment::Create,
                      'organization_label' => content_view.organization.label,
                      'cp_id' => content_view_environment.cp_id,
                      'name' => content_view_environment.label,
                      'description' => content_view.description)
end

[iNecas]

@parthaa do you plan to add the tests for the rest of added actions? I see only Organization create

@iNecas Added tests for the rest of them.. Need your help for the library_create_test. For some reasons the fixtures don't load for just that one test..
When I run parthaa@5dadeb5#diff-20 I get an error like https://gist.github.com/parthaa/9354826
Note the action in the gist seems to think its running Actions::Headpin::Environment::Create while its actually running ::Actions::Headpin::Environment::LibraryCreate .. Do I need to change this section ?

    describe "Create" do
       let(:action_class) { ::Actions::Headpin::Environment::LibraryCreate }
       let(:action) { create_action action_class }
      ....
    end

@parthaa yes: change "Create" to "LibraryCreate". the fixtures are not working probaby because thery are not loaded into the spec directly. I preffer FactoryGirl, as it allows to build object without actually saving it, which works usually better when testing actions, saving some unnecessary calls to db.

@iNecas weirdly enough I fixed this with this hack....
parthaa@a3e5839#diff-482caa01bfe25cd1cdb410483d83d83bR17

I changed ->

- describe ::Actions::Headpin::Environment do
+ describe ::Actions::Headpin::ContentView do

for some reason all the fixtures load fine the second I do this change..

[parthaa]

@daviddavis can I ack myself on this :).......

[iNecas]

@bkearney @parthaa the foreman-tasks waiting for action fixed and released in 0.3.5

[parthaa]

[test]

[daviddavis]

Was this intentional? It looks off.

[daviddavis]

APJ

[daviddavis]

[test]

[parthaa]

sounds like a plan... Thanks @daviddavis and @iNecas !