Package Delete via changeset #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| add_delete_content("delete_package", :packageid, repo_id, pkg_id_list) | ||
| # we need to optimize this call | ||
| # need a faster way to get pulp 'package object' | ||
| # information. |
There was a problem hiding this comment.
Recommend adding TODO to to the comment, to help ensure that we revisit it. Also, if need enhancement to pulp, please create BZ and recommend referencing it.
Perhaps this is something that will be resolved when Katello moves to Pulp v2.
|
ACK and merging. |
bbuckingham
added a commit
that referenced
this pull request
Jul 28, 2012
Package Delete via changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial Backend + UI work get the complete package delete workflow.
Promotions -> Add Packages to delete to changesets -> Review -> Delete should actually delete the package in the correct repo and regenerate metadata