Fixes #5422 - don't orchestrate user at login every login #4070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK |
iNecas
added a commit
that referenced
this pull request
May 13, 2014
Fixes #5422 - don't orchestrate user at login every login
| # update was caused by loging into the system: no need to run | ||
| # orchestration for that, as it causes locking troubles and might | ||
| # lead to performance issues as well | ||
| unless (changes.keys - ["last_login_on", "updated_at"]).empty? |
There was a problem hiding this comment.
This isn't passing. This needs to be %w(last_login_on updated_at)
There was a problem hiding this comment.
Damn you, Rubocop (and me not waiting for CI), thanks @ehelms for fixing
There was a problem hiding this comment.
I have to say that this is one of the style rules I am least fond of.
|
In the future, please don't merge unless Jenkins is green. |
|
Mistakes happen, but please remain vigilant to not just merge if you have an ACK. This commit introduced a rubocop issue to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.