buildroot and %clean section is not needed #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # we need to keep RHEL compatibility | ||
| BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) | ||
|
|
There was a problem hiding this comment.
So I assume its not needed for RHEL6 anymore. But how about RHEL5? I am not sure if we support this for CLI.
|
👍 Looks OK to me. Only katello-agent need to support RHEL5 I guess. |
see http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag It is needed only for EL5, but we do not support server on EL5
|
fixed, in fact in katello-agent is was removed week ago in commit 30a0a56 |
|
Oh good. All others are fine I guess. |
lzap
added a commit
that referenced
this pull request
Aug 2, 2012
buildroot and %clean section is not needed
lzap
added a commit
that referenced
this pull request
Apr 27, 2013
buildroot and %clean section is not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
It is needed only for EL5, but we do not support server on EL5