New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #5535, adding permissions for host collections. #4096
Fixes #5535, adding permissions for host collections. #4096
Conversation
@@ -71,7 +71,7 @@ def param_rules | |||
def index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this controller as part of this work or are you preferring to do that with your V1 controller cleanup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's marked as deleted in the v1 controller cleanup.
@ehelms updated. |
So this route - http://10.13.129.54:3000/katello/api/v2/systems/bulk-actions?fields=full appears to be being caught by system#show action and throws a candlepin error since 'bulk-actions' is not a system ID which means I cannot access the host collections page. |
@ehelms did you restart rails after checking out these changes? I'm not sure how that could happen, I see the host collections page just fine. ETA: ah, you mean the bulk action content host host collection page. |
@ehelms the error you describe above happens in master. Perhaps it is related to the system -> content host rename? |
refute @host_collection.editable? | ||
end | ||
|
||
def test_key_deletable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
key
- what's a key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy/paste fail, will fix.
APJ |
Fixes #5535, adding permissions for host collections.
http://projects.theforeman.org/issues/5535