-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI generator #410
CLI generator #410
Conversation
@@ -0,0 +1,143 @@ | |||
#http://code.google.com/p/inflectorpy/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really do not like copy'n'paste code form wild internet without thinking about license and updates.
Can you please create package inflectorpy, give it correct license and require it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd accept license in this file with the note where it was taken from, its a bit of code rather than a library ;-)
I packed the code into python-inflector package. It's available in our nightly repos. The original inflector.py file has been deleted. |
$ spacewalk-pylint generate.py |
# in this software or its documentation. | ||
# | ||
|
||
import os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import os is not used
beside those coding errors it looks good. |
I recommend to merge it and we can improve those code quality things later on since Tom is out. |
Agreed, they are just warning and recommendation. Nothing too hard. |
This utility semi-automatically generates python code for Katello CLI
based on json exports from apipie documentation tool.
It generates: