fixes #5742/BZ1098152 - fix consumer action to display failure message #4222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… message This commit contains a minor change so that if the user provides an invalid package or package group name as part of an action (e.g. install/update/remove), the error message returned by pulp is displayed. Without this change, the user will get a stack trace as are no 'resolved' or 'deps' information in the result. With this change the user would see the following messages as provided by pulp: 1. installing an invalid package: *:invalidpackagename-*-*.*: No package(s) available to install 2. installing an invalid package group: No Group named invalidgroupname exists
|
ACK tested this and it works great. catches bad names for packages and groups no effect on correctly named items (still adds/removes fine) |
bbuckingham
added a commit
that referenced
this pull request
Jun 9, 2014
fixes #5742/BZ1098152 - fix consumer action to display failure message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains a minor change so that if the user provides an
invalid package or package group name as part of an action
(e.g. install/update/remove), the error message returned by
pulp is displayed.
Without this change, the user will get a stack trace as are no
'resolved' or 'deps' information in the result.
With this change the user would see the following messages as
provided by pulp:
:invalidpackagename--.: No package(s) available to install
No Group named invalidgroupname exists