Fixes #5719 - make pulp async actions cancellable #4238
Conversation
| message = if task[:exception] | ||
| Array(task[:exception]).join('; ') | ||
| elsif task[:error] | ||
| "#{task[:error][:code]}: #{task[:error][:description]}" | ||
| elsif task[:state] == 'canceled' | ||
| "Task canceled" |
There was a problem hiding this comment.
This doesn't need to be handled here (can open an issue if so), but do these need to be marked for i18n and translated at display time?
There was a problem hiding this comment.
Yeah, better with it than without it
The cancelling is done though the task details: running steps tab
|
note that this requires a new version of python-kombu http://repos.fedorapeople.org/repos/pulp/pulp/testing/6Server/x86_64/python-kombu-3.0.15-10.pulp.el6.noarch.rpm After installing that, cancelling a sync seemed to work. Let me tag the kombu into katello nightly |
|
Playing with this a tad more it seems sort of annoying that when i click cancel, i have to sit and wait a while before it shows up as cancelled. In my case I went an cancelled it twice and pulp came back and threw an ISE because i was trying to cancel a non-stopped task. resetting the suspend time would help with this, maybe we should try that first |
|
@jlsherrill Could you re-test, should give the best results with theforeman/foreman-tasks#69 |
|
The foreman-tasks with the improvements in waiting for the canceling released with foreman-tasks-0.6.3 |
|
@iNecas much much better!! ACK |
Fixes #5719 - make pulp async actions cancellable
The cancelling is done though the task details: running steps tab