Fixes #6195, bz1109386 - 403 on cv version delete #4279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the authorize_* calls should all consistently return either true or false. |
| end | ||
|
|
||
| def authorize_system_content_view(options) | ||
| if options[:system_content_view_id] |
There was a problem hiding this comment.
I'd probably assign this to a variable to shorten line 77.
| module Katello | ||
| module Concerns::Authorization::Api::V2::ContentViewsController | ||
| extend ActiveSupport::Concern | ||
| included do |
There was a problem hiding this comment.
Nit pick - empty line between the extend and the included.
Content view remove call specifying versions and envs to be removed / unasssociated had a minor glitch -> env_ids - @view.environment_ids.map(&:to_s)).empty? env_ids = [1,2,3] while @view.environment_ids.map(&:to_s) = [1,2,3] Problem was API was treating it like a list of strings while params code changed it to ints This commit should fix that issue
|
ACK for me. @daviddavis final call on you |
|
|
parthaa
added a commit
that referenced
this pull request
Jun 20, 2014
Fixes #6195, bz1109386 - 403 on cv version delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content view remove call specifying versions and envs to be removed / unasssociated
had a minor glitch -> env_ids - @view.environment_ids.map(&:to_s)).empty?
env_ids = [1,2,3] while @view.environment_ids.map(&:to_s) = [1,2,3]
Problem was API was treating it like a list of strings while params code changed it to ints
This commit should fix that issue