Fixes #5952, BZ1079174 - Fixes issue with content view filter name and d... #4296
Conversation
|
@adamruzicka I have added you to our contributor group and if you go here (https://github.com/orgs/Katello/members) and set your membership to public future pull requests will get automatically tested. |
|
[test] |
| $scope.working = false; | ||
| }; | ||
|
|
||
| var success = function (response) { |
There was a problem hiding this comment.
We prefer declaring all vars at the top of the function and then assigning them below. I will add this to the code conventions.
|
[test] |
|
@adamruzicka can you please squash those two commits and rebase this PR? |
| @@ -228,6 +229,12 @@ angular.module('Bastion.content-views').config(['$stateProvider', function ($sta | |||
| controller: 'PackageFilterController', | |||
| templateUrl: 'content-views/details/filters/views/package-filter-details.html' | |||
| }) | |||
| .state('content-views.details.filters.details.rpm.edit', { | |||
| url: '/edit', | |||
There was a problem hiding this comment.
These states are going to need permissions now that #4382 has been merged. I believe these will all be permission: 'edit_content_views'.
|
When I update the description of a filter the description is included in the JSON sent to the server but the description is not updated in the response. |
|
@waldenraines should work now |
|
@adamruzicka can you squash those two commits? |
…name and description being impossible to edit
|
I still cannot save a filter's description:
|
|
I tried this again and it worked, must have been PEBCAK, ACK. |
Fixes #5952, BZ1079174 - Fixes issue with content view filter name and d...
|
thanks, I'm glad it got sorted out |
...escription being impossible to edit