fixes #6373 - make lifecycle_environment_ids accessible

[stbenjam]

Smart Proxies can now have lifecycle environments, but when adding a Smart
Proxy through the UI, it fails with a mass assignment error.

[jlsherrill]

ah good find. this will fix creation but still allows someone to select lifecycle environments upon creation and simply establishes the AR relationship (Ignoring the associations in pulp). See here how we handle update by intercepting the update call: https://github.com/Katello/katello/blob/master/app/controllers/katello/concerns/smart_proxies_controller_extensions.rb

Ideally we would:

a) not show a lifecycle environment tab on create
or
b) incorporate the same level of intercepting on the create call.

My vote would be a) for its simplicity and also about the fact that eventually this tab will be feature dependent. If the 'pulp' feature isn't there, the tab will not be shown, so it can't really be on the create screen anyways.

[stbenjam]

@jlsherrill Ah, I didn't understand how this was working originally but I think I do now. I disable the tab entirely on creation now.

Are there instructions around on how to get a Foreman smart proxy with content up and running so I can test that updating the lifecycle environment works?

[jlsherrill]

@stbenjam Looks good to me! I'm pretty sure i answered that question for you, but i'll put it here for reference:

https://github.com/Katello/katello-installer#production-examples

First use capsule-certs-generate & and then run capsule-installer on the capsule to be

ACK, let me know if you want me to merge it.

[stbenjam]

@jlsherrill Yup, it's good! Merge away.