fixes #6512 - move valid notices routes inside resources block #4393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| get "notices/note_count" | ||
| get "notices/get_new" | ||
| get "notices/auto_complete_search" | ||
| resources :notices do |
There was a problem hiding this comment.
Might want to add a :only=>[] to this, otherwise by default rails will automatically add 7 routes including create/update/index/
|
APJ once comments are addressed |
In Rails 3.2.8, it's not seeing the previous notice route get_new as being part of the engine. Moving inside a resource block fixes that problem. I also removed 2 routes that aren't valid and shouldn't exist anymore - note_count and auto_complete_search.
|
@parthaa Fixed |
|
ACK |
waldenraines
pushed a commit
that referenced
this pull request
Jul 14, 2014
fixes #6512 - move valid notices routes inside resources block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails 3.2.8, it's not seeing the previous notice route get_new as
being part of the engine. Moving inside a resource block fixes that
problem. I also removed 2 routes that aren't valid and shouldn't exist
anymore - note_count and auto_complete_search.