fixes #6572 - fix default check on path selector #4438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also do not allow unselect by default, since it does not make sense in most cases. Added an option "required-selection" to path selector that default to true
| mode="singleSelect"> | ||
| </span> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div alch-form-group label="{{ 'Content View' | translate }}"> | ||
| <select ng-hide="contentViews.length === 0" | ||
| <select ng-hide="contentViews.length === 0 || activationKey.environment === undefined " |
There was a problem hiding this comment.
Is this check of activationKey.environment for when the activation key is still loading?
There was a problem hiding this comment.
no its when there is no environment selected. Prior to this you could check the environment, then uncheck it and the list of content views would stay present.
|
ACK |
jlsherrill
added a commit
that referenced
this pull request
Jul 16, 2014
fixes #6572 - fix default check on path selector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also do not allow unselect by default, since it
does not make sense in most cases. Added an option
"required-selection" to path selector that default to true