Fixes #6759/BZ1108928: using #content as topbar.js expects. #4478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foreman's topbar.js expects an element with an id of "content" that it adds top padding the size of the header to in order for there to be sufficient room for the floating header. This commit renames #maincontent to #content so Foreman's topbar.js works for katello pages. http://projects.theforeman.org/issues/6759 https://bugzilla.redhat.com/show_bug.cgi?id=1108928
|
ACK |
waldenraines
pushed a commit
that referenced
this pull request
Jul 24, 2014
Fixes #6759/BZ1108928: using #content as topbar.js expects.
AsherBond
pushed a commit
to AsherBond/katello
that referenced
this pull request
Aug 23, 2014
AsherBond
pushed a commit
to AsherBond/katello
that referenced
this pull request
Aug 23, 2014
Refs Katello#4478 - Add support for localized API docs
mbacovsky
added a commit
to mbacovsky/katello
that referenced
this pull request
Mar 16, 2015
ehelms
added a commit
that referenced
this pull request
Mar 17, 2015
Refs #4478 - API localization - Apipie setup moved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foreman's topbar.js expects an element with an id of "content"
that it adds top padding the size of the header to in order for
there to be sufficient room for the floating header. This commit
renames #maincontent to #content so Foreman's topbar.js works for
katello pages.
http://projects.theforeman.org/issues/6759
https://bugzilla.redhat.com/show_bug.cgi?id=1108928