Fixes #6828/BZ1104636: show correct version of puppet module. #4501
Conversation
| return puppetModule.version; | ||
| }); | ||
|
|
||
| latest = angular.copy(puppetModules[puppetModules.length - 1]); |
There was a problem hiding this comment.
While I agree this is OK for the client to ensure, what about default ordering of puppet modules coming from the server and/or requesting sorted modules from the server?
There was a problem hiding this comment.
I could do that if we really wanted to, however, I went ahead and put it here since we're already modifying the response here. I could move all of this logic to the server though if you have a strong preference.
There was a problem hiding this comment.
What is this API returning in terms of data right now? I can see returning the data by default sorted by version as helpful to more than just the UI. Or at least, accepting sort params and us calling the API to get the data sorted how we want as I think this benefits more use cases.
There was a problem hiding this comment.
Currently the API simply returns the puppet module versions in an nondeterministic order.
There was a problem hiding this comment.
I still think the API is the best place to do it as there is more benefit there and this keeps ordering more consistent with how we do it in other places.
There was a problem hiding this comment.
If you're going the API route, you may want to consider removing the available_puppet_modules action and just using puppet_modules#index. I think you could just add some filters like not_in_content_view_id, name, etc. along with your sort param.
|
Blocked by #4540. |
The latest version of puppet modules was being incorrectly calculated, based on an incorrect assumption that the last item in the array was the latest version. This commit explicitly sorts the puppet modules by the version such that the latest version is correct. http://projects.theforeman.org/issues/6828 https://bugzilla.redhat.com/show_bug.cgi?id=1104636
|
@ehelms updated, I could not do the grouping server side (and thus the "Use Latest") because we don't support that in |
|
ACK |
Fixes #6828/BZ1104636: show correct version of puppet module.
The latest version of puppet modules was being incorrectly
calculated, based on an incorrect assumption that the last
item in the array was the latest version. This commit
explicitly sorts the puppet modules by the version such that
the latest version is correct.
http://projects.theforeman.org/issues/6828
https://bugzilla.redhat.com/show_bug.cgi?id=1104636