Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6995: restore pulp_celerybeat to list of services to restart. #4552

Merged
merged 1 commit into from Aug 8, 2014

Conversation

waldenraines
Copy link
Contributor

The service pulp_celerybeat was removed from the list of services
restarted with a katello:reset during the pulp 2.4 upgrade. Restarting
the service is working fine now so this commit restores pulp_celerybeat
to the list of services to start/stop during katello:reset.

http://projects.theforeman.org/issues/6995

…start.

The service pulp_celerybeat was removed from the list of services
restarted with a katello:reset during the pulp 2.4 upgrade. Restarting
the service is working fine now so this commit restores pulp_celerybeat
to the list of services to start/stop during katello:reset.

http://projects.theforeman.org/issues/6995
@ehelms
Copy link
Member

ehelms commented Aug 7, 2014

@waldenraines what does "working fine" mean in this context mean? Is there a test scenario for this or a pulp developer who can thumbs up it?

@waldenraines
Copy link
Contributor Author

"Working fine" as in restarting it is no longer a problem.

This first came about because I was speaking with @jlsherrill about pulp_celerybeat being stopped after a katello reset. He said we used to restart it during a katello reset but had to remove that during the 2.4 migration. I reset several times with this in place and everything worked as expected. I'm not sure how I got into the state of pulp_celerybeat not running but I am not the only one who has been in that state.

@jlsherrill
Copy link
Member

@ehelms yeah, i chatted with bmbouter and we did remove it from that list previously the issues that required that are now resolved. So we should add it back in case you update pulp and run a katello:reset. The fact that it is dying he does thing is a bug and we're investigating.

@jlsherrill
Copy link
Member

ACK

jlsherrill added a commit that referenced this pull request Aug 8, 2014
Fixes #6995: restore pulp_celerybeat to list of services to restart.
@jlsherrill jlsherrill merged commit b1f9913 into Katello:master Aug 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants