Fixes #7362 - Update org create dynflow #4642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthaa
force-pushed
the
new-org
branch
3 times, most recently
from
0cfa346
to
0e0679c
Compare
|
@parthaa looks like this needs a rebase, I'll attempt to test it once you do |
|
@ehelms rebased |
| self.organization.reload #must reload organization, otherwise old name is saved | ||
| self.organization.update_index | ||
| #self.organization.reload #must reload organization, otherwise old name is saved | ||
| #self.organization.update_index |
|
I attempted, through the UI to create an org with the following: Name: Bvlah And got this in the UI: |
parthaa
force-pushed
the
new-org
branch
3 times, most recently
from
6c8ddc1
to
7116397
Compare
|
@ehelms try now |
|
[test] |
|
[test] |
1 similar comment
|
[test] |
|
|
||
| sequence do | ||
| if ::Katello.config.use_cp | ||
| cp_create = plan_action(Candlepin::Owner::Create, | ||
| label: organization.label, | ||
| name: organization.name) | ||
|
|
||
| plan_action(Environment::LibraryCreate, organization.library) |
There was a problem hiding this comment.
Why is this action inside the Katello.config.use_cp condition?
Moved it to follow org destroy model. Removed the create orchestration off sync_action and made the controllers use the orchestrated action directly. Needed this for tests related to issue Katello#6946 to work. Also updated unit tests to deal with this change. Also removed the unused org elastic search bindings more more
|
ACK |
parthaa
added a commit
that referenced
this pull request
Sep 15, 2014
Fixes #7362 - Update org create dynflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved it to follow org destroy model. Removed the create orchestration off
sync_action and made the controllers use the orchestrated action
directly. Needed this for tests related to issue #6946 to work.
Also updated unit tests to deal with this change.